Re: [[patch] domxml ./. fix for some memory leaks + cleanups]

Hello Lukas, IMO we're too deep into the release process to just fix some memleaks. For all we know this may break some things. Therefore I would like to see this patch not applied. Derick On Thu, 4 Apr 2002, Lukas Schroeder wrote: > hi derick! > > imho, this patch should find a way into 4.2.0 as it fixes several > memory leaks. > it been applied to HEAD already, but hasn't been merged into PHP_4_2_0 > yet. attached you find a version against the PHP_4_2_0 branch. > > hope you like it enough to apply it during the current release cycle... > > > regards, > -lukas > > > ----- Forwarded message from Lukas Schroeder <lukas@edeal.de> ----- > > Date: Thu, 4 Apr 2002 12:38:37 +0200 > From: Lukas Schroeder <lukas@edeal.de> > To: php-dev@lists.php.net > Subject: [PHP-DEV] [patch] domxml ./. fix for some memory leaks + cleanups > > hi! > > this patch is against current cvs. it contains some trivial cleanups > and fixes for several memory leaks, where memory that gets malloc()ed in > libxml2 is not free()d. please apply... > > > additionally, this patch changes get_attribute() to return > FALSE instead of an empty string if the attribute does not exists. > without this change, php code cannot distinguish between a missing and > an empty attribute. i hope this gets applied too... > > > regards, > -lukas > > > ----- End forwarded message ----- >