Re: Fwd: [PATCH] Re: [Sab] Seg Fault with Sablotron

Melvyn, as you know this stuff better then I, can you please make sure this stuff gets committed and merged as it should be? If after these changes old sablotrons don't work anymore, I also think we should let configure emit an error. Derick On Mon, 22 Jul 2002, Melvyn Sopacua wrote: > At 19:38 7/22/2002 +0200, derick@php.net wrote: > > >On Mon, 22 Jul 2002, Marko Karppinen wrote: > > > > > on 22.7.2002 20:33, derick@php.net at derick@php.net wrote: > > > > > > > Hello, > > > > > > > > the logic in this patch looks ok, but it totally violates coding > > > > standards. Also, after this patch does it still work with older > > > > sablotron installations? > > > > > > Didn't Sterling already commit this to HEAD? > > As the contributor Lenar, explained, the first fix (incompatibilities on the > with the Sablotron API) are in HEAD (not on PHP_4_2_0 branch). > > The other fix in this - the non existing function reference and resulting > crash isn't fixed. > > I could make a patch against HEAD or 420 branch, which ever you like, providing > the HEAD fixes are merged into the branch first. > > There's also one patch on the Sablotron site - is that merged/committed yet? > > > > Met vriendelijke groeten / With kind regards, > > Webmaster IDG.nl > Melvyn Sopacua > > <@Logan> I spent a minute looking at my own code by accident. > <@Logan> I was thinking "What the hell is this guy doing?" > http://www.geekissues.org/quotes/top50.html?6824 > --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ---------------------------------------------------------------------------