Re: PHP Test results

Your patch seems good, i just updated my PHP4.2.x repository and executed the tests: [marcus@zaphod PHP_4_2_0]$ export TESTS=ext/exif/tests/*.phpt;make test

Check for exif_read_data                                             ... passed
Check for exif_thumbnail                                             ... passed
Check for exif_read_data                                             ... passed

TEST RESULT SUMMARY =============================

Number of tests:     3
Tests skipped:       0 (0.0%)
Tests failed:        0 (0.0%)
Tests passed:        3 (100%)

============================= Skipped 0 extensions. PHP Version: 4.2.3-dev I'll commit a patch for the warnings but not for that in line 1403 which is in internal debug mode only. marcus At 09:47 03.09.2002, derick@php.net wrote:

Markus, Sebastian, I fixed all the #ifdef stuff here, Marcus, can you check the mismatches? Derick On Tue, 3 Sep 2002 noreply@php.net wrote: ./configure\\\' \\\'--prefix=/usr/local\\\' \\\'--enable-exif\\\' \\\'--enable-track-vars\\\' \\\'--with-calendar=shared\\\' \\\'--enable-safe-mode\\\' \\\'--enable-magic-quotes\\\' \\\'--enable-trans-sid\\\' \\\'--enable-wddx\\\' \\\'--enable-ftp\\\' \\\'--with-openssl=/usr/local\\\' \\\'--with-oci8=/appl/oracle/product/8.1.6\\\' \\\'--with-mysql=/usr/local/mysql\\\'', 'problems' => '[.....] --------^ cc: Warning: exif.c, line 2313: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #endif

--------^ cc: Warning: exif.c, line 2345: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #ifdef EXIF_DEBUG

--------^ cc: Warning: exif.c, line 2347: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #endif

--------^ cc: Warning: exif.c, line 2351: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #ifdef EXIF_DEBUG

--------^ cc: Warning: exif.c, line 2353: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #endif

--------^ cc: Warning: exif.c, line 2357: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #ifdef EXIF_DEBUG

--------^ cc: Warning: exif.c, line 2359: # not in column 1 is ignored, skipping to end of line. (ignoretokens)

        #endif

--------^ cc: Error: exif.c, line 1403: In this statement, a common type could not be determined for the 2nd and 3rd operands (\\"(value_ptr?value_ptr:\\"<no data>\\")\\" and \\"exif_get_tagformat(...)\\") of a conditional operator. (badcondit)

        php_error(E_NOTICE,\\"process tag(x%04x=%s,@x%04X+x%04X(=%d)): %s\\", tag, exif_get_tagname(tag,tagname), value_ptr-offset_base, byte_count, byte_count, format==TAG_FMT_STRING?(value_ptr?value_ptr:\\"<no data>\\"):exif_get_tagformat(format));

-------------------------------------------------------------------------------------------------------------------------------------------------------------^

cc: Warning: exif.c, line 1783: In this statement, the referenced type of the pointer value \\"(char ...)Data\\" is \\"signed char\\", which is not compatible with \\"unsigned char\\". (ptrmismatch)

                                exif_process_COM(ImageInfo, (char *)Data, itemlen);

------------------------------------------------------------^ cc: Warning: exif.c, line 1975: In this statement, the referenced type of the pointer value \\"dir_entry\\" is \\"unsigned char\\", which is not compatible with \\"signed char\\". (ptrmismatch)

exif_process_IFD_TAG(ImageInfo,dir_entry,ImageInfo->sections[sn].Data-dir_offset,ifd_size,section_index,0);

-------------------------------------------------------------------------------^

cc: Warning: exif.c, line 1975: In this statement, the referenced type of the pointer value \\"ImageInfo->sections[sn].Data-dir_offset\\" is \\"unsigned char\\", which is not compatible with \\"signed char\\". (ptrmismatch)

exif_process_IFD_TAG(ImageInfo,dir_entry,ImageInfo->sections[sn].Data-dir_offset,ifd_size,section_index,0);

-----------------------------------------------------------------------------------------^

*** Exit 1 Stop. *** Exit 1 Stop. *** Exit 1 Stop. *** Exit 1 Stop. ', 'bugids' => 'unknown, bugs.php.net is down at the moment, but i reported this some time ago and it was fixed...', 'remarks' => '', ) -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ ---------------------------------------------------------------------------

                 PHP: Scripting the Web - derick@php.net
                    All your branches are belong to me!
                SRM: Script Running Machine - www.vl-srm.net

---------------------------------------------------------------------------