Re: Re: cvs: php4 /ext/iconv/tests translit.phpt

As the original reporter of the bug #16069 (and the author of this test), the test should be intended specifically for EUC-JP (or ISO-2022-JP) transliteration. Because it is not really a transliteration test, as the bug turned out to be a kind of buffer allocation problem. If you are confused with the name of this test case, what about simply renaming it "bug #16069"? Melvyn Sopacua <msopacua@idg.nl> wrote: > > At 20:41 9-10-2002, Moriyoshi Koizumi wrote: > > >Hi, > > > >I confirmed this test might not work even with libiconv, when the errno > >test run by configure failed. > > > >IMO it has something to do with other EUC-JP related failures on BSD > >platforms. > > Ok - so split up the tests in two? > > It's better to know, translit is not working for EUC-JP, than to think > translit is not working period. > > > > > > > >Moriyoshi Koizumi > > > > > >"Rui Hirokawa" <rui_hirokawa@ybb.ne.jp> wrote: > > > > > hirokawa Wed Oct 9 08:54:52 2002 EDT > > > > > > Modified files: > > > /php4/ext/iconv/tests translit.phpt > > > Log: > > > added @ to suppress a notice. > > > > > > > > > Index: php4/ext/iconv/tests/translit.phpt > > > diff -u php4/ext/iconv/tests/translit.phpt:1.4 > > php4/ext/iconv/tests/translit.phpt:1.5 > > > --- php4/ext/iconv/tests/translit.phpt:1.4 Wed Sep 4 01:17:16 2002 > > > +++ php4/ext/iconv/tests/translit.phpt Wed Oct 9 08:54:52 2002 > > > @@ -1,7 +1,7 @@ > > > --TEST-- > > > ICONV: LIBICONV transliteration (bug #16069) > > > --SKIPIF-- > > > -<?php include( 'skipif.inc' ); if( iconv('CP932', > > > 'EUC-JP//TRANSLIT', > > "\x87\x6d") == '' ) die("skip\n"); ?> > > > +<?php include( 'skipif.inc' ); if( @iconv('CP932', > > > 'EUC-JP//TRANSLIT', > > "\x87\x6d") == '' ) die("skip\n"); ?> > > > --POST-- > > > --GET-- > > > --FILE--