Re: Re: More testcases

Vilerage wrote:

Erm... Some of those already existed. I was looking in the wrong directory. Correct set is only: is_long_basic.phpt - http://pastebin.com/md3dc06e Ok - thanks again, tests aren't always were you expect them to be :-) In general they stay pretty close to the structure of the source code, but not always.

I was looking around for somewhere to suggest that you looked at. I wondered about /ext/standard/pack?. The gcov data shows it as about 70% covered (http://gcov.php.net/PHP_5_3/lcov_html/standard/pack.c.gcov.php) which may mean that it's missing error and variation tests. There are two tests already in /ext/standard/tests/strings/pack.phpt and unpack.phpt - they are quite long. Anyway - just a suggestion. Zoe