[Fwd: Re: [PHP-DEV] TestFest reviewers needed]

Lukas - PS - to elaborate slightly on what I meant by 'a significant amount of time'. Yesterday I added 5 tests. The first CVS commit was at 14:11, the last at 16:59. So lets say 3 hours work. I checked tests on Linux 32 and Linux 64, and PHP5.3 & PHP6 - so that's 20 checks in total, as I said some of them needed fixes. Usually I would also check Windows but could not get access to a Windows machine yesterday - that would have made it 30 checks. In addition to just checking, a little re-work was required and I had to rebuild PHP 6 and 5 with zlib for some tests. This was all *after* Pierre had looked at the tests to check that they generally made sense for GD. At the moment PHP5.3 and PHP6 usually only need different tests when there is unicode/string output. PHP5.2 and PHP5.3 have diverged a bit recently and are beginning to need different test cases more often. For example in one of the tests I added yesterday uses a constant IMAGETYPE_ICO, which is only supported in PHP5.3 +. In view of the time it takes to commit tests it seemed to me reasonable (and in line with the documentation here:http://qa.php.net/testfest.php) to only commit in HEAD&PHP5.3 - but as I said - we ought to all agree to do the same thing. Zoe