Fwd: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/general_functions var_export-locale.phpt

Hi! A quick note about locale and windows support: As you may noticed, I fixed a couple of locale related tests on windows and enabled some other. The idea is to have more portable tests instead of platform specific versions. The latter is harder to debug and are often not updated or synced (be solaris, sun or windows). I need some help to review other tests and do the same tricks I did. It will be amazingly helpful to improve PHP portability. Feel free to ping me if you have any question, Example: ---------- Forwarded message ---------- -if (!setlocale(LC_ALL, "de","de_DE","de_DE.ISO8859-1","de_DE.ISO_8859-1","de_DE.UTF-8")) { +if (!setlocale(LC_ALL, "german", "de","de_DE","de_DE.ISO8859-1","de_DE.ISO_8859-1","de_DE.UTF-8")) { die("skip locale needed for this test is not supported on this platform"); } Other example: ext/standard/tests/strings strtolower.phpt (using 'C' on windows for US/ASCII) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org