Re: tests for prev

Thanks for the feedback/comments, glad the tests were okay. I've written some more tests for array_product() and put them in the same place (http://soal.org/ilewis/product), and I've also applied for a CVS id. It doesn't seem to be too much hastle to make the tests run on 5.3 and 5.2 so unless there is a good reason not to, I'm happy to keep writing them for both 5.2/5.3 and 6 as well.? Hannes Magnusson wrote:

On Thu, Sep 11, 2008 at 21:01, Lars Strojny <lstrojny@php.net> wrote:

Hi Iain, Am Donnerstag, den 11.09.2008, 12:53 +0100 schrieb Iain Lewis:

Hello, I've written a few tests for prev() that I'd like to submit. Could someone take a look at them and let me know if they are okay/commit them if they are?

The tests were pretty good, I've committed them to 5_3 and HEAD. Given, that 5_3 is close to being released it's not really worth messing around with 5_2.

Excuse me? What does "messing around with 5.2" mean? Sure there will be new release of 5.2, its not dead yet.

I'm hoping to write some more tests, probably continuing with array functions to start with, so I will apply for a CVS id if the tests are okay?

I would support that, just send a mail to internals.

That won't help. All CVS account requests have to go through the request form at http://php.net/cvs-php -Hannes