Re: new test ftp_mdtm

Nathaniel McHugh wrote:

Hi there, I'm keen to write new tests. I've written one for the ftp_mdtm function. It can be downloaded here http://www.fishtrap.co.uk/php_tests/ftp_mdtm_basic.phpt . The test required a change to the ftp tests server.inc to allow it to respond to the ftp MDTM command. I have included a diff here http://www.fishtrap.co.uk/php_tests/server.inc.diff or the complete altered file here http://www.fishtrap.co.uk/php_tests/server.inc . In common with all the other ftp tests it will be skipped on Windows systems due to of the lack of pcntl_fork. Great - thanks! I've checked the test on PHP52 and PHP53 - passes.

It fails on PHP6 but I think that might be missing implementation in PHP6, I'll check and commit with an --XFAIL-- section if that's the case.

On a general note this function was picked out pretty much at random. It's hard to know where to concentrate your efforts, which functions and extensions need tests writting for them the most. Has anybody any suggestions? If not I might have a go at some more ftp ones. Sounds good - there don't seem to be many there.

Zoe