Re: testfest related bug fixes

2009/5/10 Johannes Schlüter <johannes@php.net>: > Hi, > > during testfest some bugs were found, which is good (well, the good part > is they were found, not that they existed ;-) ), and fixed. When > committing a fix please make sure to commit a test for the bug, too. > Even when a test is waiting in the testfest repo. > > Some random reasons, not sorted, not complete: > > - The test in the tesfest repo might not end up in CVS > - The test might be refactored so the bug doesn't occur before >  committing > - The test in he testfest repo checks expected behavior, the one >  committed with the fix verifies the bug fix > - It's better to have a test too much than missing a test And make sure the test follows the normal bug filenames, i.e. bugXXXX.phpt :) -Hannes