Re: report from nyc testfest
| From: | Daniel Convissor | Date: | Sun, 24 May 2009 18:35:25 +0000 |
| Subject: | Re: report from nyc testfest | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65005@lists.php.net to get a copy of this message | ||
Hi Zoe:
> When you add stuff in SVN please would you add any files that the tests
> depend on too?
Oh. So we need to copy over files that are already in CVS? I figured we
only need to put in new files, then the test harness would extract the
files from both SVN and CVS before running any tests.
If all includes/etc need to be added, we'll need to get the the
skipif.inc into SVN too. Hmm, but I see the results website is showing
the tests are passing. Maybe that's because the include fails in the
SKIPIF section, but who cares, because the output from the failure isn't
"skip" :). If so, then it seems it would be a good idea to for
run-tests.php's SKIPIF parser to watch for various error/warning/notice
messages and kvetch if there's an issue.
Checking the results website output for the tests I put in for any skipif
output indicates that the skipif output isn't stored. But something odd
did come up.
The tests I submitted (DOMDocument_schemaValidateSource_basic_NewYorkUG
and DOMDocument_schemaValidate_basic_NewYorkUG) are shown in the grid of
all tests as having passed. But looking at the output of the test (by
clicking on "PASS" in the 5.3 column and then "Actual Output" it says
file get contents was unable to find book.xsd. Something is wrong.
> I noticed there were a couple in there this morning that
> needed book.xml and book.xsd, so I added those already.
Huh? I added book.xsd into SVN in the same commit that added the tests
that use it.
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409