Re: FW: [PHP-QA] cvs: php-benchmarks /benchcli bench.php /benchcli/data pcre-data.xml /benchcli/misc timer.php /benchcli/tests test_ackermann.php
test_deltablue.php test_gaussjordan.php test_pcre.php test_raytrace.php /benchcli/tests/raytracer Backgr

Hi Alexander, On Thu, May 28, 2009 at 2:07 PM, Alexander Hjalmarsson <hjalle@sgh.se> wrote: > First of all, I forwarded the email to myself so I could reply here instead of in Outlook. > That's why it can look a little bit messy at some parts. Nice, but it think it breaks threading ;-) >> > >> > http://cvs.php.net/viewvc.cgi/php-benchmarks/benchcli/tests/test_gaussjordan.php?view=markup&rev=1.1 >> > Index: php-benchmarks/benchcli/tests/test_gaussjordan.php >> > +++ php-benchmarks/benchcli/tests/test_gaussjordan.php >> >> There are no comments in this file >> This is a bit "microbenchmark-y" for my liking. Is there a reason to >> include it? > > We could either skip it totally or include it in the micro benchmark > directory. I would vote for inclusion in the micro benchmark directory since > it's written now, but if it's totally pointless, then it shouldn't be there > either. I wouldn't say its pointless, but I wouldn't spend time commenting it (maybe just a TODO comment). > This, as well as the the ackermann test is taken from roadsend. I'll add > origins (I don't know what license to write as it's a copy from the > roadsend). I'll also place it within the micro benchmark directory. If you add a comment giving its original URL, that should be fine. You can leave the ackermann as is, since it already credits the Language Shootout, which is its original source. Thanks for making the changes, everything looks good. Paul -- Paul Biggar paul.biggar@gmail.com