new run-tests
| From: | Greg Beaver | Date: | Fri, 03 Jul 2009 03:33:56 +0000 |
| Subject: | new run-tests | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-65174@lists.php.net to get a copy of this message | ||
Hi,
I'm looking at using the new run-tests implementation inside Pyrus, and
am a bit concerned at some of the assumptions. It seems that all of the
configuration code assumes that it is running from an application where
it has absolute control over $argv and friends. A much better design
would be to separate these dependencies, write some classes whose sole
purpose is parsing $argv to set up the configuration, and let other
programs like Pyrus do their own configuration setup and pass that in.
As it is designed now, I have to extend rtWinConfiguration and
rtUnixConfiguration just to stop it from trying to parse $argv.
Of course, I could manually construct a fake $argv, but that's pretty
wasteful and a weird way to call the API. :)
Greg