Re: AW: [PHP-QA] The new run-tests.php...

Hi

Schuermann Sebastian schrieb:

Maybe add a new --COMMAND-- --SEQUENTIAL-- for things that need to be executed one after another. The more you try NOT creating bad smells in tests, the more you can execute in parallel. But I guess the mysql testcases incorporate a ressouce (the db) that can't be parallelized or decoupled. Theory meets practice ;), so a new --SEQUENTIUAL-- might help ;) We are not actually running single tests in parallel - we are running 'groups of tests' in parallel with other 'groups of tests'. A group is currently defined as 'all the tests in a directory' and tests in a group are run sequentially. So, as long as the MySQL tests are all in the same directory - they won't be run at the same time as each other but they will be run at the same time as tests in other directories.

We think it's possible that some groups of tests cannot be run at the same time as _anything_ else, we plan on a group configuration file which will exist in the same directory as the tests and can be used to specify 'sequential only', it can also be used for a directory level --SKIPIF-- which is another thing we need.

You never know what bad smell may be in the future... Currently many MySQL tests use the same table called "test". If you run two MySQL tests in parallel, concurrent accesses to the table "test" may clash and cause false positives. It is possible to change the MySQL tests to run in parallel. Every test run through run-test.php run should have its own unique PID. It can't be too hard to add that to the table names that tests may create (change table.inc). Thanks to the ("new") --CLEAN-- section all those tables can be cleaned up properly after the test run. I don't think you need to change anything :-)

Z