Re: New run-tests code

On Wed, Sep 9, 2009 at 13:14, Pierre Joye<pierre.php@gmail.com> wrote: > hi Derick, > > > On Wed, Sep 9, 2009 at 12:04 PM, Derick Rethans<derick@php.net> wrote: > >> Yes, I do. We picked the original behavior so that we can make our tests >> work in every environment. It provides a better spread of code and >> settings in the wild. > > We did not do it by design. There are tests (less every day) that are > still dependent on the system php.ini, but they should be fixed > instead (splited if necessary). > > The concept of unit tests is not to write generic tests but to test It is. And it isn't. The generic tests do not have --INI-- sections. The test that are targeted at special ini obscurity have --INI-- sections. > each single unique cases we can figure out, different ini settings are > different cases. It also makes testing and debugging much easier, and Exactly. And there is no way we can duplicate every single test case for the 1million ini variations. That is the whole point of running the tests on the users setups. Getting more obscure setups to run the tests and make sure they work. If the test fails then a) the test is br0ken and needs fixing or b) there is a bug in PHP Stuff like html_errors, prevision, MQ.. and others that break perfectly valid tests are overwritten, and the rest of the users INI should be pulled in, especially stuff like Derick and I have mentioned. > it helps to actually analyze feedbacks as well without having to ask > ten times if there are no system php.ini being loaded. Whom are you asking? The test failure mails contain the ini values that were used and any other info you could possibly need. If thats not enough, then fix the reporting to add the info you think you may need. -Hannes