Comments about http://wiki.php.net/qa/phptlessonslearned

Hello all, I've read this document and found it very interesting. I was also introduced for the first time to generate-phpt.php, useful :) A few notes about the document: The page says: "This script was written by Zoe Slattery (thank you!) and can be found in the PHP 5_3 source code in scripts/dev/generate_phpt.php. Although it’s in the 5_3 source code, I think I’m right in saying that it can be used to create tests for all versions of PHP." 0. The script resides in scripts/dev/generate-phpt/src/generate-phpt.php, not scripts/dev/generate_phpt.php. 1. It may work with 5_2 [haven't tried] but currently it tests the return value of phpversion() and die()s in case the minor < 3. 2. Very minor and is about the script itself, not the document, but I think it would be best to use the PHP_MINOR_VERSION const [added in 5.2.7] or version_compare(). -- May the source be with you, Best regards, Jess Portnoy