Re: change easter_date as XFAIL
| From: | Eric Stewart | Date: | Fri, 19 Mar 2010 15:15:54 +0000 |
| Subject: | Re: change easter_date as XFAIL | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65522@lists.php.net to get a copy of this message | ||
On Fri, Mar 19, 2010 at 6:04 AM, Olivier Doucet <webmaster@ajeux.com> wrote:
> Hello there,
>
> I was reviewing all failed test on PHP 5.2.13 and found this one :
> /ext/calendar/tests/easter_date.phpt
>
> This test is failing for years. A bug report was already filled in january
> 2007:
> http://bugs.php.net/bug.php?id=40213
>
> The test is always returning fail. I wonder if we should temporarily edit
> the test to report an XFAIL.
> I don't know if this would be a bad idea or not, as this bug would be even
> less viewed and not taken care of.
>
> What's your point of view everyone ?
>
> Olivier
>
Is there currently a plan to do what's alluded to in the bug report, which
is rewriting ext/calendar to use ext/date types and utilities? This sounds
like a change that might be best served with an RFC and official acceptance
of the RFC into a release. Once the RFC has been accepted, that would be a
good time to change the PHPT to XFAIL. I'm recommending this under the
assumption that the ext/calendar conversion isn't a small change.
Eric Lee Stewart