Re: Re: Difference in warning string for PHP5.2 and PHP5.3
| From: | Felix De Vliegher | Date: | Sat, 05 Jun 2010 13:11:06 +0000 |
| Subject: | Re: Re: Difference in warning string for PHP5.2 and PHP5.3 | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65565@lists.php.net to get a copy of this message | ||
Hi
The issue here is the difference between parameter handling in 5.2 and 5.3 (which has the improved
parameter handling), that's why I suggested to Stefan to mention it here:
5.3:
if (zend_parse_parameters_none() == FAILURE) {
return;
}
5.2:
if (ZEND_NUM_ARGS() != 0) {
WRONG_PARAM_COUNT;
}
I could fix this in 5.2 if no one has problems with it.
Cheers,
Felix
On 5-jun-2010, at 14:09, Stefan Koopmanschap wrote:
> Hi all,
>
> I encountered a similar situation for sqlite_libencoding, and have
> solved it in a similar way
>
> Stefan
>
> On Sat, Jun 5, 2010 at 1:31 PM, Stefan Koopmanschap
> <stefan.koopmanschap@gmail.com> wrote:
>> Hi all,
>>
>> While working on the tests for PHP TestFest in Maastricht, I came by a
>> function that is generating a warning (in the error testcase, so the
>> fact that a warning is generated is correct) that has a different
>> warning string for PHP5.2 than for PHP5.3. Felix suggested I send an
>> e-mail to this list to report this situation.
>>
>> I have committed the testcases now with two different testcases, one
>> for 5.2 and one for 5.3, with SKIPIF blocks to make sure they only get
>> executed on the right version as sqlite_libversion_error_php52.phpt
>> and sqlite_libversion_error_php53.phpt
>>
>> Sincerely,
>>
>> --
>> Stefan Koopmanschap
>> http://www.stefankoopmanschap.nl/
>> http://www.leftontheweb.com/
>>
>
>
>
> --
> Stefan Koopmanschap
> http://www.stefankoopmanschap.nl/
> http://www.leftontheweb.com/
>
> --
> PHP Quality Assurance Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>