Re: tests/basic/021.phpt typo
| From: | Eyal Teutsch | Date: | Wed, 17 Nov 2010 15:04:29 +0000 |
| Subject: | Re: tests/basic/021.phpt typo | ||
| References: | 1 2 3 4 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65672@lists.php.net to get a copy of this message | ||
Hi Felipe & Patrick,
thank you both for your prompt replies.
How do I actually obtain commit access to tests?
thx,
Eyal
On 11/17/2010 04:51 PM, Felipe Pena wrote:
2010/11/17 Patrick ALLAERT <patrickallaert@php.net <mailto:patrickallaert@php.net>>Forgot to "reply to all" (fixed).2010/11/17 Patrick ALLAERT <patrickallaert@php.net <mailto:patrickallaert@php.net>>:Hi Eyal, 2010/11/17 Eyal Teutsch <eyal.t@zend.com <mailto:eyal.t@zend.com>>:Hi, 021.phpt under tests/basic has a typo in it's INI section - it has: file_upload=1 while should actually be (with a 's'): file_uploads=1 Should I commit to both:http://svn.php.net/repository/php/php-src/branches/PHP_5_2/tests/basic/021.phpt
http://svn.php.net/repository/php/php-src/branches/PHP_5_3/tests/basic/021.phptIf you have commit access to these tests, feel free to do so,
this isindeed a typo which should be fixed! Don't forget to also adapt the file in trunk: http://svn.php.net/repository/php/php-src/trunk/tests/basic/021.phpt Opss, I supposed you have no access, then committed the fix. If you have, just commit next time! :P -- Regards, Felipe Pena