Re: "Warning: Invalid CRT parameters detected" warnings on windows

On Wed, Dec 8, 2010 at 12:35 PM, Eyal Teutsch <eyal.t@zend.com> wrote: > On 12/08/2010 01:25 PM, Derick Rethans wrote: > >> On Wed, 8 Dec 2010, Eyal Teutsch wrote: >> >> Didn't actually mean that they should be changed in PHP source itself, >>> but >>> whether the patterns that are tested should be changed, as all of these >>> tests >>> seem to fail. >>> >> They work on non-windows just fine, so please don't reduce the test >> cases. >> >> Also, please no top-posting! >> >> regards, >> Derick >> >> Please note that the above mentioned tests: > gmstrftime_variation9 > > gmstrftime_variation11 > gmstrftime_variation13 > gmstrftime_variation15 > gmstrftime_variation17 > gmstrftime_variation19 > and their equivalent strftime_variation tests, all have a SKIPIF section, > which allows them to run on windows ONLY: > --SKIPIF-- > <?php > if (strtoupper(substr(PHP_OS, 0, 3)) != 'WIN') { > die("skip Test is valid for Windows"); > } > > Hence, there does not seem to be much point in leaving them as is. > > maybe we could modify the tests to expect failure, I mean if those formatting codes aren't supported on windows, then we should test that they fail, but if the php just pass them along, then I don't think that testing this would make much sense. Tyrael