some linux error specific strings in some sockets tests EXPECTF sections
| From: | Eyal Teutsch | Date: | Tue, 14 Dec 2010 08:43:34 +0000 |
| Subject: | some linux error specific strings in some sockets tests EXPECTF sections | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-65714@lists.php.net to get a copy of this message | ||
Hi,
The following sockets tests seem to fail on non linux OS (windows, mac, os/400):
A) socket_connect_params, socket_read_params, socket_getpeername
B) socket_write_params
C) socket_strerror
Suggested fixes:
The tests in group A fail as these tests expect in their output, a string such as:
Warning: socket_connect(): unable to connect [%i]: Transport endpoint is already connected in %s on line %i
The 'Transport endpoint is already connected' part is OS specific, and hence I suggest to change this expected line to:
Warning: socket_connect(): unable to connect [%i]: %a in %s on line %i
The test in group B, fail as of similar reason - has in it's --EXPECTF-- section:
Warning: socket_write(): unable to write to socket [%i]: Broken pipe in %s on line %i
Here again, changing 'Broken pipe' to %a makes the test pass.
The test of group C is linux specific (looks for all socket error strings) - suggest I would add to it's SKIPIF section a check whether running on linux.
thx,
T