Re: com web/qa: Corrected overflow for wide code listings.: pulls/index.php pulls/pullrequests.js
| From: | Alexey Shein | Date: | Sat, 31 Mar 2012 12:58:55 +0000 |
| Subject: | Re: com web/qa: Corrected overflow for wide code listings.: pulls/index.php pulls/pullrequests.js | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-66201@lists.php.net to get a copy of this message | ||
Hey, David!
Thanks for merging this, but it seems Johannes wasn't quite satisfied
with this solution, although that's still better than nothing :)
28 марта 2012 г. 12:57 пользователь David Soria Parra <dsp@php.net>
написал:
> Commit: 022351febcbd4697f250b6db8373dd7e8c364bcc
> Author: Shein Alexey <confik@gmail.com> Wed, 28 Mar 2012 12:57:36 +0500
> Parents: 6d039775214cd7ea53a1812d9177e853d315aacb
> Branches: master
>
> Link:
> http://git.php.net/?p=web/qa.git;a=commitdiff;h=022351febcbd4697f250b6db8373dd7e8c364bcc
>
> Log:
> Corrected overflow for wide code listings.
>
> Changed paths:
> M pulls/index.php
> M pulls/pullrequests.js
>
>
> Diff:
> 022351febcbd4697f250b6db8373dd7e8c364bcc
> diff --git a/pulls/index.php b/pulls/index.php
> index 43acfc1..314c936 100644
> --- a/pulls/index.php
> +++ b/pulls/index.php
> @@ -20,7 +20,7 @@ common_header();
> <tr>
> <td width="10"><img src="../gfx/spacer.gif"
> width="10" height="1"></td>
> <td width="100%">
> - <style>
> + <style type="text/css">
> #loading {
> position:fixed;
> top:50%;
> @@ -33,7 +33,7 @@ common_header();
> background-color: black;
> color: white;
> text-align: center;
> - vertical-align: center;
> + vertical-align: middle;
> }
>
> .ghuser {
> @@ -56,6 +56,10 @@ common_header();
> #repoPullList code {
> white-space: pre;
> }
> +
> + #repoContent {
> + width: 920px;
> + }
> </style>
> <link
> href="http://code.jquery.com/ui/1.8.18/themes/ui-lightness/jquery-ui.css"
> rel="stylesheet" type="text/css"/>
> <script type="text/javascript"
> src="http://code.jquery.com/jquery-1.7.1.min.js"></script>
> diff --git a/pulls/pullrequests.js b/pulls/pullrequests.js
> index db82020..9a88b4c 100644
> --- a/pulls/pullrequests.js
> +++ b/pulls/pullrequests.js
> @@ -121,6 +121,7 @@ function loadRepo(repo) {
> data.data[key].body = converter.makeHtml(data.data[key].body);
> }
> $("#repoContent").html(
> $("#repoOverviewTemplate").render([{repoName: repo, pullList:
> $("#pullRequestListItem").render(data.data)}]));
> + $("#repoContent
> code").parent('p').css('overflow', 'auto');
> $(".pullinstructions").click(function(ev) {
>
> $('<div></div>').html($("#pullInstructionTemplate").render({ repo:
> repo, number: $(this).attr("number")}))
> .dialog({title:
> $(this).attr("number")+': '+$(this).attr("title")+'
> ('+$(this).attr("state")+')', width: 800 });
>
>
> --
> PHP Quality Assurance Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Regards,
Shein Alexey