com phpruntests: fixing phar/tests/005.phpt on windows: src/testcase/sections/rtExecutableSection.php

Commit: 9f971feb49bca84ce2996910b45dcc6aaebba102 Author: Zoe Slattery <zoe@php.net> Wed, 5 Aug 2009 21:04:55 +0000 Parents: a3d514e4bc7dcd79356231b6e833e46eba3ef189 Branches: master Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=9f971feb49bca84ce2996910b45dcc6aaebba102 Log: fixing phar/tests/005.phpt on windows Changed paths: M src/testcase/sections/rtExecutableSection.php Diff: diff --git a/src/testcase/sections/rtExecutableSection.php b/src/testcase/sections/rtExecutableSection.php index 17d5219..f79ecc0 100644 --- a/src/testcase/sections/rtExecutableSection.php +++ b/src/testcase/sections/rtExecutableSection.php @@ -25,8 +25,9 @@ abstract class rtExecutableSection extends rtSection protected function writeExecutableFile() { - // @todo I think \n could be replaced with PHP_EOL here - need to check on Windows. - $contentsAsString = implode("\n", $this->sectionContents) . PHP_EOL; + // Don't even think anout replacing the \n with PHP_EOL + // It causes stuff (ext/phar/tests/005.phpt) on windows. + $contentsAsString = implode("\n", $this->sectionContents) . "\n"; file_put_contents($this->fileName, (binary) $contentsAsString); }