com phpruntests: bugfix outputwriter: src/taskScheduler/rtTaskScheduler.php src/testcase/output/rtTestOutputWriterCSV.php
src/testcase/output/rtTestOutputWriterList.php
| From: | David Soria Parra | Date: | Mon, 20 Jul 2009 11:04:48 +0000 |
| Subject: | com phpruntests: bugfix outputwriter: src/taskScheduler/rtTaskScheduler.php src/testcase/output/rtTestOutputWriterCSV.php src/testcase/output/rtTestOutputWriterList.php |
||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66320@lists.php.net to get a copy of this message | ||
Commit: a0e2fa43ea0312ceb4a532da62e18cd24b0704bd
Author: Georg Gradwohl <g2@php.net> Mon, 20 Jul 2009 11:04:48 +0000
Parents: 5f58751a57ad1bc4a9a3d4a2a80811a1b6f2cb9b
Branches: master
Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=a0e2fa43ea0312ceb4a532da62e18cd24b0704bd
Log:
bugfix outputwriter
Changed paths:
M src/taskScheduler/rtTaskScheduler.php
M src/testcase/output/rtTestOutputWriterCSV.php
M src/testcase/output/rtTestOutputWriterList.php
Diff:
diff --git a/src/taskScheduler/rtTaskScheduler.php b/src/taskScheduler/rtTaskScheduler.php
index 008ca4a..ff3569c 100644
--- a/src/taskScheduler/rtTaskScheduler.php
+++ b/src/taskScheduler/rtTaskScheduler.php
@@ -131,7 +131,7 @@ class rtTaskScheduler
$task->run();
$results = $task->getResult();
rtTestOutputWriter::flushResult($results, $this->reportStatus);
- $this->resultList = array_merge($this->resultList, $results);
+ $this->resultList[] = $results;
}
return;
diff --git a/src/testcase/output/rtTestOutputWriterCSV.php
b/src/testcase/output/rtTestOutputWriterCSV.php
index 5924c43..725dc81 100644
--- a/src/testcase/output/rtTestOutputWriterCSV.php
+++ b/src/testcase/output/rtTestOutputWriterCSV.php
@@ -25,16 +25,22 @@ class rtTestOutputWriterCSV extends rtTestOutputWriter
public function createOutput()
{
- foreach ($this->resultList as $testResult) {
+ foreach ($this->resultList as $testGroupResults) {
+
+ foreach ($testGroupResults as $testResult) {
+
$outputString = $testResult->getName();
$testStatus = $testResult->getStatus();
- foreach($testStatus->getTestStateNames() as $name) {
+
+ foreach($testStatus->getTestStateNames() as $name) {
+
if($testStatus->getValue($name)) {
$outputString .= " , ". strtoupper($name);
}
}
$this->output .= $outputString."\n";
}
+ }
}
}
diff --git a/src/testcase/output/rtTestOutputWriterList.php
b/src/testcase/output/rtTestOutputWriterList.php
index c537e53..27e0b0b 100644
--- a/src/testcase/output/rtTestOutputWriterList.php
+++ b/src/testcase/output/rtTestOutputWriterList..php
@@ -3,7 +3,7 @@
* rtTestOutputWriterList
*
* Write test output line by line
- *
+ *
* @category Testing
* @package RUNTESTS
* @author Zoe Slattery <zoe@php.net>
@@ -12,32 +12,37 @@
* @copyright 2009 The PHP Group
* @license http://www.php.net/license/3_01.txt PHP License 3.01
* @link http://qa.php.net/
- *
+ *
*/
class rtTestOutputWriterList extends rtTestOutputWriter
{
public function __construct()
{
- $this->type = 'txt';
+ $this->type = 'txt';
}
-
+
public function createOutput()
{
- foreach ($this->resultList as $testResult) {
- $outputString = "";
- $testStatus = $testResult->getStatus();
-
- foreach($testStatus->getTestStateNames() as $name) {
+ foreach ($this->resultList as $testGroupResults) {
+
+ foreach ($testGroupResults as $testResult) {
+
+ $outputString = "";
+ $testStatus = $testResult->getStatus();
+
+ foreach($testStatus->getTestStateNames() as $name) {
- if ($testStatus->getValue($name)) {
- $outputString .= " ". strtoupper($name);
- $outputString .= " " . $testStatus->getMessage($name);
- }
- }
- $outputString .= " " . $testResult->getTitle();
- $outputString .= " [" . $testResult->getName() . ".phpt]";
- $this->output ..= $outputString."\n";
+ if ($testStatus->getValue($name)) {
+ $outputString .= " ". strtoupper($name);
+ $outputString .= " " . $testStatus->getMessage($name);
+ }
+ }
+
+ $outputString .= " " . $testResult->getTitle();
+ $outputString .= " [" . $testResult->getName() . ".phpt]";
+ $this->output .= $outputString."\n";
+ }
}
}