com phpruntests: Part one of fix to Georg's code: src/testcase/output/rtTestOutputWriterCSV.php src/testcase/output/rtTestOutputWriterList.php
| From: | David Soria Parra | Date: | Fri, 17 Jul 2009 17:31:07 +0000 |
| Subject: | com phpruntests: Part one of fix to Georg's code: src/testcase/output/rtTestOutputWriterCSV.php src/testcase/output/rtTestOutputWriterList.php | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66330@lists.php.net to get a copy of this message | ||
Commit: f022a1e61c9c27ab7f3f9bab6441faf9313000dd
Author: Zoe Slattery <zoe@php.net> Fri, 17 Jul 2009 17:31:07 +0000
Parents: 3b9dab5d3531b655f7dca1bc88d379d33f5f0cce
Branches: master
Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=f022a1e61c9c27ab7f3f9bab6441faf9313000dd
Log:
Part one of fix to Georg's code
Changed paths:
M src/testcase/output/rtTestOutputWriterCSV.php
M src/testcase/output/rtTestOutputWriterList.php
Diff:
diff --git a/src/testcase/output/rtTestOutputWriterCSV.php
b/src/testcase/output/rtTestOutputWriterCSV.php
index 725dc81..5924c43 100644
--- a/src/testcase/output/rtTestOutputWriterCSV.php
+++ b/src/testcase/output/rtTestOutputWriterCSV.php
@@ -25,22 +25,16 @@ class rtTestOutputWriterCSV extends rtTestOutputWriter
public function createOutput()
{
- foreach ($this->resultList as $testGroupResults) {
-
- foreach ($testGroupResults as $testResult) {
-
+ foreach ($this->resultList as $testResult) {
$outputString = $testResult->getName();
$testStatus = $testResult->getStatus();
-
- foreach($testStatus->getTestStateNames() as $name) {
-
+ foreach($testStatus->getTestStateNames() as $name) {
if($testStatus->getValue($name)) {
$outputString .= " , ". strtoupper($name);
}
}
$this->output .= $outputString."\n";
}
- }
}
}
diff --git a/src/testcase/output/rtTestOutputWriterList.php
b/src/testcase/output/rtTestOutputWriterList.php
index 27e0b0b..c537e53 100644
--- a/src/testcase/output/rtTestOutputWriterList.php
+++ b/src/testcase/output/rtTestOutputWriterList.php
@@ -3,7 +3,7 @@
* rtTestOutputWriterList
*
* Write test output line by line
- *
+ *
* @category Testing
* @package RUNTESTS
* @author Zoe Slattery <zoe@php.net>
@@ -12,37 +12,32 @@
* @copyright 2009 The PHP Group
* @license http://www.php.net/license/3_01.txt PHP License 3.01
* @link http://qa.php.net/
- *
+ *
*/
class rtTestOutputWriterList extends rtTestOutputWriter
{
public function __construct()
{
- $this->type = 'txt';
+ $this->type = 'txt';
}
-
+
public function createOutput()
{
- foreach ($this->resultList as $testGroupResults) {
-
- foreach ($testGroupResults as $testResult) {
-
- $outputString = "";
- $testStatus = $testResult->getStatus();
-
- foreach($testStatus->getTestStateNames() as $name) {
+ foreach ($this->resultList as $testResult) {
+ $outputString = "";
+ $testStatus = $testResult->getStatus();
+
+ foreach($testStatus->getTestStateNames() as $name) {
- if ($testStatus->getValue($name)) {
- $outputString .= " ". strtoupper($name);
- $outputString .= " " . $testStatus->getMessage($name);
- }
- }
-
- $outputString .= " " . $testResult->getTitle();
- $outputString .= " [" . $testResult->getName() . ".phpt]";
- $this->output .= $outputString."\n";
- }
+ if ($testStatus->getValue($name)) {
+ $outputString .= " ". strtoupper($name);
+ $outputString .= " " . $testStatus->getMessage($name);
+ }
+ }
+ $outputString .= " " . $testResult->getTitle();
+ $outputString .= " [" . $testResult->getName() . ".phpt]";
+ $this->output .= $outputString."\n";
}
}