com phpruntests: using PHP_EOL instead of \n: src /testcase/sections/rtExecutableSection.php
| From: | David Soria Parra | Date: | Sun, 17 May 2009 20:02:46 +0000 |
| Subject: | com phpruntests: using PHP_EOL instead of \n: src /testcase/sections/rtExecutableSection.php | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66444@lists.php.net to get a copy of this message | ||
Commit: 6973b578a0076b3a9c0ae41871f4b258e815c37e
Author: Zoe Slattery <zoe@php.net> Sun, 17 May 2009 20:02:46 +0000
Parents: b55ff8f6fa67ab9eefbd2f831d2eb2d3bbe55a65
Branches: master
Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=6973b578a0076b3a9c0ae41871f4b258e815c37e
Log:
using PHP_EOL instead of \n
Changed paths:
M src/testcase/sections/rtExecutableSection.php
Diff:
diff --git a/src/testcase/sections/rtExecutableSection.php
b/src/testcase/sections/rtExecutableSection.php
index 24c0424..0d47361 100644
--- a/src/testcase/sections/rtExecutableSection.php
+++ b/src/testcase/sections/rtExecutableSection.php
@@ -13,8 +13,9 @@ abstract class rtExecutableSection extends rtSection
}
protected function writeExecutableFile()
- {
- $contentsAsString = implode("\n", $this->sectionContents) . "\n";
+ {
+ // @todo I think \n could be replaced with PHP_EOL here - need to check on Windows.s
+ $contentsAsString = implode("\n", $this->sectionContents) . PHP_EOL;
file_put_contents($this->fileName, (binary) $contentsAsString);
}