com phpruntests: modification to setting nameing: src/configuration/rtRuntestsConfiguration.php
| From: | David Soria Parra | Date: | Wed, 13 May 2009 01:36:57 +0000 |
| Subject: | com phpruntests: modification to setting nameing: src/configuration/rtRuntestsConfiguration.php | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66474@lists.php.net to get a copy of this message | ||
Commit: 9fe7e053e81c51965c18607b381f5c679d3d73ae
Author: Zoe Slattery <zoe@php.net> Wed, 13 May 2009 01:36:57 +0000
Parents: 3129f621496b11597fc7f0d1ec040b087fb6b38b
Branches: master
Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=9fe7e053e81c51965c18607b381f5c679d3d73ae
Log:
modification to setting nameing
Changed paths:
M src/configuration/rtRuntestsConfiguration.php
Diff:
diff --git a/src/configuration/rtRuntestsConfiguration.php
b/src/configuration/rtRuntestsConfiguration.php
index af5906d..025223d 100644
--- a/src/configuration/rtRuntestsConfiguration.php
+++ b/src/configuration/rtRuntestsConfiguration.php
@@ -35,14 +35,15 @@ abstract class rtRuntestsConfiguration
private $commandLine;
private $settingNames = array (
- 'rtCurrentDirectorySetting',
- 'rtWorkingDirectorySetting',
- 'rtLogFormatSetting',
- 'rtPhpExecutableSetting',
- 'rtPhpCgiExecutableSetting',
- 'rtTestFileSetting',
- 'rtTestDirectorySetting',
- 'rtPhpCommandLineArgSetting',
+
+ 'CurrentDirectory' => 'rtCurrentDirectorySetting',
+ 'WorkingDirectory' => 'rtWorkingDirectorySetting',
+ 'LogFormat' => 'rtLogFormatSetting',
+ 'PhpExecutable' => 'rtPhpExecutableSetting',
+ 'PhpCgiExecutable' => 'rtPhpCgiExecutableSetting',
+ 'TestFiles' => 'rtTestFileSetting',
+ 'TestDirectories' => 'rtTestDirectorySetting',
+ 'PhpCommandLineArguments' => 'rtPhpCommandLineArgSetting',
);
protected function init()
@@ -66,10 +67,11 @@ abstract class rtRuntestsConfiguration
$options->parseAdditionalOptions($this->commandLine, $this->environmentVariables);
//set configuration
- foreach ($this->settingNames as $className) {
+ foreach ($this->settingNames as $name => $className) {
$object = new $className($this);
- $this->settings[$className] = $object->get();
+ $this->settings[$name] = $object->get();
}
+ //1 var_dump($this->settings);
//check configuration preconditions
$preConditionList = rtPreConditionList::getInstance();
@@ -102,6 +104,8 @@ abstract class rtRuntestsConfiguration
public function getSetting($settingName)
{
+ //echo "$settingName $this->settings[$settingName] \n";
+ //var_dump($this->settings);
return $this->settings[$settingName];
}