run-tests vs phpruntests
| From: | zoe slattery | Date: | Tue, 15 May 2012 15:23:38 +0000 |
| Subject: | run-tests vs phpruntests | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66556@lists.php.net to get a copy of this message | ||
Does anyone have any strong views on how 'forgiving' run-tests.php should be? For example, this test:
ext/libxml/tests/bug61367-read.phpt
has this --INI-- section:
--INI--
open_basedir=.
; Suppress spurious "Trying to get property of non-object" notices
error_reporting=E_ALL & ~E_NOTICE
run-tests.php just ignores any line that is not of the form 'something=somethingelse', in the parallel run-tests.php code we currently throw an exception in an INI setting is not of the form 'something=somethingelse', so this test won't run because of the 'comment' line.
The behaviour should be consistent which can be achieved either by modifying tests or making the new code do what run-tests.php currently does.
I have a slight preference for not allowing anything in an INI section except an ini setting, this would mean changing these two tests.
Anyone have strong views either way?
Zoe