com phpruntests: A second fix to empty sections and adding timing benchmark: QA/QATimedBucket.tgz src/testcase/preconditions/rtHasNoEmptySections.php
src/testrun/rtPhpTestRun.php

Commit: a0186aee4d2207977f1a935022ad9c5727bf9556 Author: zoe slattery <zoe@php.net> Thu, 17 May 2012 08:36:15 +0100 Parents: a1146b7ac01651668acae6e3995b2e01fa2f6ebc Branches: master Link: http://git.php.net/?p=phpruntests.git;a=commitdiff;h=a0186aee4d2207977f1a935022ad9c5727bf9556 Log: A second fix to empty sections and adding timing benchmark Changed paths: A QA/QATimedBucket.tgz M src/testcase/preconditions/rtHasNoEmptySections.php M src/testrun/rtPhpTestRun.php Diff: diff --git a/QA/QATimedBucket.tgz b/QA/QATimedBucket.tgz new file mode 100644 index 0000000..f51e70f Binary files /dev/null and b/QA/QATimedBucket.tgz differ diff --git a/src/testcase/preconditions/rtHasNoEmptySections.php b/src/testcase/preconditions/rtHasNoEmptySections.php index 5007f66..b5b9047 100644 --- a/src/testcase/preconditions/rtHasNoEmptySections.php +++ b/src/testcase/preconditions/rtHasNoEmptySections.php @@ -49,12 +49,17 @@ class rtHasNoEmptySections implements rtTestPreCondition } } - //Catch an empty section at the end + //Catch an empty section, section header then blank line if($this->isSectionHeading($thisLine)) { if($nextLine == ""){ return false; } } + + //catch an empty section, last line is a section header + if($this->isSectionHeading($nextLine)) { + return false; + } return true; } diff --git a/src/testrun/rtPhpTestRun.php b/src/testrun/rtPhpTestRun.php index d27a00a..929dd31 100644 --- a/src/testrun/rtPhpTestRun.php +++ b/src/testrun/rtPhpTestRun.php @@ -47,7 +47,6 @@ class rtPhpTestRun // $preConditionList->check($this->commandLine, $this->environmentVariables); $preConditionList->check($runConfiguration); - exit(); //Write PHP executable name to the array of env variables. Some //test cases expect to be able to use it.