Re: new test
| From: | Erwin Poeze | Date: | Wed, 27 Jun 2012 06:43:50 +0000 |
| Subject: | Re: new test | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-66652@lists.php.net to get a copy of this message | ||
Op 27-06-12 02:19, Christopher Jones schreef:
>
>
> On 06/20/2012 12:53 PM, Erwin Poeze wrote:
>> Hi,
>>
>> I've created a new test for class_exists, variation 4, see attachment.
>>
>> Could you take a look at it if this a the way it should be? How should
>> I proceed to get the test accepted and added to the suite?
>>
>> Thanks,
>> Erwin
>>
>>
>>
>>
>
> Technically you could use --EXPECT-- instead of --EXPECTF--
> You could also credit yourself if you want using --CREDITS--.
> See http://qa.php.net/phpt_details.php
>
> Currently the best way to submit PHP changes is via a github
> pull request: https://github.com/php/php-src/pulls
>
> Chris
>
Thanks, there are two commits waiting for approval:
https://github.com/php/php-src/pull/117
Erwin