com web/qa: Let's not index report details. There is little to gain from having the specifics of a test run in search indices and there is a lot of
risk of data exposure: include/functions.php reports/details.php
| From: | Rasmus Lerdorf | Date: | Sat, 22 Jun 2013 16:02:02 +0000 |
| Subject: | com web/qa: Let's not index report details. There is little to gain from having the specifics of a test run in search indices and there is a lot of risk of data exposure: include/functions.php reports/details.php |
||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-66903@lists.php.net to get a copy of this message | ||
Commit: 3ae7a5ca5e29c1f36c4d42017bd17a9737775541
Author: Rasmus Lerdorf <rasmus@php.net> Sat, 22 Jun 2013 09:02:02 -0700
Parents: 17f728e7021fead0cf69c9b72b72e8b62a14f13d
Branches: master
Link: http://git.php.net/?p=web/qa.git;a=commitdiff;h=3ae7a5ca5e29c1f36c4d42017bd17a9737775541
Log:
Let's not index report details.
There is little to gain from having the specifics of a test run
in search indices and there is a lot of risk of data exposure
Changed paths:
M include/functions.php
M reports/details.php
Diff:
diff --git a/include/functions.php b/include/functions.php
index e231193..cf9b5c9 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -6,7 +6,7 @@ Read an Learn. Any Questions so ask.
Version: $Id$
*/
-function common_header() {
+function common_header($extra_headers=NULL) {
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
@@ -14,6 +14,13 @@ function common_header() {
<title><?php echo $GLOBALS["TITLE"]; ?></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="MSSmartTagsPreventParsing" content="TRUE">
+<?php
+if(!empty($extra_headers)) {
+ foreach($extra_headers as $header) {
+ echo $header."\n";
+ }
+}
+?>
<link rel="stylesheet" href="/styles.css" type="text/css">
</head>
diff --git a/reports/details.php b/reports/details.php
index 44fdb87..80709c2 100644
--- a/reports/details.php
+++ b/reports/details.php
@@ -56,7 +56,7 @@ list($testName) = $tab->fetchArray(SQLITE3_NUM);
$database->close();
$TITLE = "Report details";
-common_header();
+common_header(array('<meta name="robots" content="noindex">'));
?>
<script src="sorttable.js"></script>
<div style="margin:10px">