com web/qa: I'll miss you tables!: include/functions.php
| From: | Hannes Magnusson | Date: | Sun, 15 Dec 2013 09:35:31 +0000 |
| Subject: | com web/qa: I'll miss you tables!: include/functions.php | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-67007@lists.php.net to get a copy of this message | ||
Commit: 22c547c01d2b7f9ebc5677b3b2d59120aaaeb165
Author: Hannes Magnusson <bjori@mongodb.com> Sun, 15 Dec 2013 01:35:31 -0800
Parents: c71470b570e7acb133cafd7beba967cf0d8bbbe0
Branches: master
Link: http://git.php.net/?p=web/qa.git;a=commitdiff;h=22c547c01d2b7f9ebc5677b3b2d59120aaaeb165
Log:
I'll miss you tables!
Use the new shared module for headers/footers
Changed paths:
M include/functions.php
Diff:
diff --git a/include/functions.php b/include/functions.php
index 47ce244..c76938f 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -7,159 +7,25 @@ Version: $Id$
*/
function common_header($extra_headers=NULL) {
-?>
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
-<html>
-<head>
- <title><?php echo $GLOBALS["TITLE"]; ?></title>
- <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
-<?php
-if(!empty($extra_headers)) {
- foreach($extra_headers as $header) {
- echo $header."\n";
+ if ($extra_headers) {
+ $HEAD_RAND = join("\n", $extra_headers);
}
-}
-?>
- <link rel="stylesheet" href="/styles.css" type="text/css">
-</head>
-
-<body bgcolor="#ffffff" text="#000000" link="#000000"
vlink="#000000" alink="#000000">
-<table width="100%" border="0" cellspacing="0"
cellpadding="0">
- <tr>
- <td bgcolor="#ffcc66"><img src="/gfx/spacer.gif"
width="5" height="1" alt="">
- <a href="http://qa.php.net/"><img
src="/gfx/logo_qa.jpg" width="111" height="58" border="0"
alt="QA logo"></a></td>
- <td bgcolor="#ffcc66" align="right" valign="bottom">
- <table border="0" cellspacing="0" cellpadding="0"
style="height:70px">
- <tr>
- <td align="right" valign="top"
class="headline_white"><?php echo date("l, F d, Y"); ?></td>
- <td align="right" valign="top"
class="headline_white"><img src="/gfx/spacer.gif" width="5"
height="1" alt=""></td>
- </tr>
- <tr>
- <td valign="bottom" align="right"><a href="/"
class="head_links">Home</a>
- | <a href="/projects.php" class="head_links">Projects and
Goals</a>
- | <a href="/rc.php" class="head_links">Release
Candidates</a>
- | <a href="/howtohelp.php" class="head_links">How to
Help</a>
- | <a href="/handling-bugs.php" class="head_links">Handling
Bug Reports</a>
- | <a href="/reports/" class="head_links">Test
Reports</a>
- | <a href="/pulls/" class="head_links">Manage Pull
Requests</a>
- </td>
- <td valign="bottom" align="right"
class="head_links"> </td>
- </tr>
- </table>
- </td>
- </tr>
- <tr>
- <td colspan="2" bgcolor="#000000" height="1"><img
alt="" src="/gfx/spacer.gif" width="1" height="1"
border="0"></td>
- </tr>
- <tr>
- <td colspan="2" bgcolor="#ff9900" align="right"
class="head_links"> </td>
- </tr>
- <tr>
- <td colspan="2" bgcolor="#000000" height="1"><img
alt="" src="/gfx/spacer.gif" width="1"
height="1"></td>
- </tr>
-</table>
-
-<table width="100%" border="0" cellspacing="0"
cellpadding="0" style="height:70%">
- <tr>
- <td width="200" bgcolor="#eeeeee" align="center"
valign="top">
- <table width="95%" border="0" cellspacing="0"
cellpadding="0">
- <tr>
- <td class="sidebox">
- <h2>PHP-QAT</h2>
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- The PHP/QA Team is a small group of developers
- whose primary goal is to support the PHP core developers by providing
- them with timely quality assurance.
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- <h2>Projects & Goals</h2>
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- Find more information about PHP/QA Team's <a
href="/projects.php">current
- projects and future goals</a>.
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- <h2>Release Candidates</h2>
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- What are <a href="/rc.php">release candidates</a> and how you can
help us testing them.
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- <h2>Contact Information</h2>
- </td>
- </tr>
- <tr>
- <td class="sidebox">
- Questions about the PHP-QAT should be sent to the
- <a href="mailto:php-qa@lists.php.net">PHP/QAT Mailing
List</a>
- <br />
- <br />
-
- Bug Reports should be submitted to the official PHP bug list
- (<a href="http://bugs.php.net/"
target="_blank">http://bugs.php.net</a>)
- <br />
- <br />
-
- All other questions should be directed to the appropriate
- <a href="http://www.php.net/support.php"
target="_blank">PHP mailing list.</a>
- </td>
- </tr>
- </table>
- <img alt="" src="/gfx/spacer.gif" width="1"
height="20"></td>
- <td style="background:url(/gfx/line_1.jpg); width: 1px;"><img
alt="" src="/gfx/spacer.gif" width="1"
height="1"><br>
-</td>
- <td align="left" valign="top" bgcolor="#FFFFFF"> <br>
-<?php
+ $TITLE = "Quality Assurance";
+ $SUBDOMAIN = "QA";
+ $CSS = array("/shared/styles/qa.css");
+ $LINKS = array(
+ array("href" => "/projects.php", "text" =>
"Projects"),
+ array("href" => "/rc.php", "text" =>
"Release Candidates"),
+ array("href" => "/howtohelp.php", "text" =>
"How to Help"),
+ array("href" => "/handling-bugs.php", "text" =>
"Handling Reports"),
+ array("href" => "/reports/", "text" =>
"Reports"),
+ array("href" => "/pulls/", "text" =>
"Pull Requests"),
+ );
+ include __DIR__ . "/../shared/templates/header.inc";
}
function common_footer() {
-?>
- </tr>
-</table>
-<table width="100%" border="0" cellspacing="0"
cellpadding="0">
- <tr>
- <td bgcolor="#000000"><img alt="" src="/gfx/spacer.gif"
width="1" height="1"></td>
- </tr>
- <tr>
- <td bgcolor="#ff9900"> </td>
- </tr>
- <tr>
- <td bgcolor="#000000"><img alt="" src="/gfx/spacer.gif"
width="1" height="1"></td>
- </tr>
-</table>
-<table width="100%" border="0" cellspacing="0"
cellpadding="0" style="height:60px">
- <tr valign="middle">
- <td bgcolor="#cccccc" align="left" width="100%">
- <table border="0" cellspacing="0" cellpadding="0">
- <tr>
- <td width="80" align="center"><a href="http://www.php.net/"><img
src="/gfx/php-logo.gif" width="69" height="36" border="0"
alt="Go to the main PHP site"></a></td>
- <td class="footer"><a href="http://www.php.net/copyright.php"
target="_blank">Copyright
- © 1997 - <?php echo date('Y', time()); ?> PHP
Group</a><br>
- All rights reserved.</td>
- </tr>
- </table>
- </td>
- <td bgcolor="#cccccc" nowrap align="right"
class="footer">Last
- update: <?php echo $GLOBALS["SITE_UPDATE"]; ?></td>
- <td bgcolor="#cccccc" nowrap align="right"
class="footer"><img alt="" src="/gfx/spacer.gif"
width="10" height="1"></td>
- </tr>
-</table>
-</body>
-</html>
-<?php
+ include __DIR__ . "/../shared/templates/footer.inc";
}
function make_link($string, $text = "", $target = "") {