com web/qa: Use correct methods to fetch form values: pulls/pullrequests.js
| From: | Hannes Magnusson | Date: | Mon, 27 Jan 2014 21:07:22 +0000 |
| Subject: | com web/qa: Use correct methods to fetch form values: pulls/pullrequests.js | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-67217@lists.php.net to get a copy of this message | ||
Commit: de0ab133c63800b0e0f1530f9aa575ca31fb1e12
Author: Hannes Magnusson <bjori@mongodb.com> Mon, 27 Jan 2014 13:06:29 -0800
Parents: e5d108fdc878e299ec6efda346c9d2339c131547
Branches: master
Link: http://git.php.net/?p=web/qa.git;a=commitdiff;h=de0ab133c63800b0e0f1530f9aa575ca31fb1e12
Log:
Use correct methods to fetch form values
This fixes changing states and commenting on prs
Changed paths:
M pulls/pullrequests.js
Diff:
diff --git a/pulls/pullrequests.js b/pulls/pullrequests.js
index 5c16461..652060d 100644
--- a/pulls/pullrequests.js
+++ b/pulls/pullrequests.js
@@ -171,8 +171,8 @@ function updateRepo(reponame, num, dia) {
action: 'ghupdate',
repo: reponame,
id: num,
- state: $("select", dia).attr("value"),
- comment: $("textarea", dia).attr("value")
+ state: $("select", dia).val(),
+ comment: $("textarea", dia).val()
}, success: function(d) {
if (d.success) {
loadRepo(reponame);