Re: cvs: qaweb /tools phport.sh

On Wed, Nov 13, 2002 at 01:22:19PM +0100, Sebastian Nohn wrote: > > On Tue, Nov 12, 2002 at 08:44:55PM -0000, Sebastian Nohn wrote: > > > nohn Tue Nov 12 15:44:55 2002 EDT > > > > > > Modified files: > > > /qaweb/tools phport.sh > > > Log: > > > Michael Mauch: "Allerdings k?nnen die alten Gurken-Shells > > (z.B. /bin/sh auf Tru64) das $(...) nicht."... > > > http://dict.leo.org/ if you really can't > > > imagine what this > > > means ;) > > > > > > - PHPSNAPFILE="$(echo $SNAPURI | sed 's/.*\///g')" > > > + PHPSNAPFILE="echo $SNAPURI | sed 's/.*\///g'" > > > > Shouldn't backquotes be used instead? > > > PHPSNAPFILE=echo $SNAPURI | sed > > > 's/.*\///g' > > Any reason for using backticks instead of normal quotes? Actually, we should use both, like on line 118: EXT="echo $PHPSNAPFILE | sed -e 's/.*\.//"; (btw: there's a typo on that line too, it needs to end with '`" and not `". All quotes should be balanced.) AFAIK, $() and backticks both cause bash to evaluate the command, while normal quotes don't. We need them both to make sure that the command still works when $PHPSNAPFILE contains whitespace. Sander