com web/qa: always hide the loading layer, no matter errors: pulls/pullrequests.js
| From: | Anatol Belski | Date: | Fri, 11 Nov 2016 20:01:21 +0000 |
| Subject: | com web/qa: always hide the loading layer, no matter errors: pulls/pullrequests.js | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-67848@lists.php.net to get a copy of this message | ||
Commit: 7a51e67974f415bfd5295d81b29bfdb206d7ee9f
Author: Anatol Belski <ab@php.net> Fri, 11 Nov 2016 21:01:21 +0100
Parents: b46a291baa6c4fd8d4915454c0634277d8e9ecfc
Branches: master
Link: http://git.php.net/?p=web/qa.git;a=commitdiff;h=7a51e67974f415bfd5295d81b29bfdb206d7ee9f
Log:
always hide the loading layer, no matter errors
Changed paths:
M pulls/pullrequests.js
Diff:
diff --git a/pulls/pullrequests.js b/pulls/pullrequests.js
index 0ba0692..e535cb3 100644
--- a/pulls/pullrequests.js
+++ b/pulls/pullrequests.js
@@ -156,8 +156,6 @@ function loadRepo(repo, url) {
$.ajax({dataType: "jsonp",
url: GITHUB_BASEURL+'repos/'+GITHUB_ORG+"/"+repo+"/issues/" +
that.data("number") + "/labels",
success: function(issue_labels) {
- $("#loading").hide();
-
var dia =
$('<div></div>').html($("#labelsDialogTemplate").render({}))
.dialog({title: that.data("number")+':
'+that.data("title")+' ('+that.data("state")+')' });
var ul_el = $("dd", dia).append('<ul style="list-style:
none;">');
@@ -187,7 +185,10 @@ function loadRepo(repo, url) {
$("button", dia).click(function() { dia.dialog("close"); });
}
});
- }
+ },
+ complete: function() {
+ $("#loading").hide();
+ }
});
ev.preventDefault();
});
@@ -251,6 +252,8 @@ function updateRepo(reponame, num, dia) {
}
window.alert(message);
}
+ }, complete: function() {
+ $("#loading").hide();
}});
dia.dialog("destroy");
}