com web/qa: Remove redundant script type="text/javascript " attributes: pulls/index.php reports/details.php reports/run_tests.php
| From: | Peter Kokot | Date: | Wed, 24 Oct 2018 18:43:21 +0000 |
| Subject: | com web/qa: Remove redundant script type="text/javascript " attributes: pulls/index.php reports/details.php reports/run_tests.php | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-68242@lists.php.net to get a copy of this message | ||
Commit: 8a377f347d65c3c94f806f31530bfa0c75a78786
Author: Peter Kokot <peterkokot@gmail.com> Wed, 24 Oct 2018 20:43:21 +0200
Parents: 8fa799a2bedfbdc1e8c97a028b6db474160008fa
Branches: master
Link: http://git.php.net/?p=web/qa.git;a=commitdiff;h=8a377f347d65c3c94f806f31530bfa0c75a78786
Log:
Remove redundant script type="text/javascript" attributes
Omitted type means that script is JavaScript [1] and for HTML 5 browsers
can be removed today.
[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
Changed paths:
M pulls/index.php
M reports/details.php
M reports/run_tests.php
Diff:
diff --git a/pulls/index.php b/pulls/index.php
index 1cfffec..50561fc 100644
--- a/pulls/index.php
+++ b/pulls/index.php
@@ -106,7 +106,7 @@ $ git push origin master # everything okay? good, let's push it
<textarea id="comment"></textarea><br>
<button>Go</button>
</script>
- <script type="text/javascript">
+ <script>
var GITHUB_BASEURL = <?php echo json_encode(GITHUB_BASEURL); ?>;
var GITHUB_ORG = <?php echo json_encode(GITHUB_ORG); ?>;
var API_URL = "api.php";
diff --git a/reports/details.php b/reports/details.php
index f26b865..9729377 100644
--- a/reports/details.php
+++ b/reports/details.php
@@ -74,7 +74,7 @@ List of reports associated</h1>
padding: 3px;
}
</style>
-<script type="text/javascript">
+<script>
function switchVisibility(elem)
{
if (elem.style.display == '' || elem.style.display == 'block') {
diff --git a/reports/run_tests.php b/reports/run_tests.php
index 4ec6442..e47a7d0 100644
--- a/reports/run_tests.php
+++ b/reports/run_tests.php
@@ -151,7 +151,7 @@ function outputTestReportsForVersion(string $getVersion) {
padding: 3px;
}
</style>
-<script type="text/javascript">
+<script>
<!--
function changeExpect()
{