com pftt2: Always use charset detector: src/com/mostc/pftt/model/core/PhptTestCase.java
| From: | Anatol Belski | Date: | Sun, 30 Dec 2018 13:05:20 +0000 |
| Subject: | com pftt2: Always use charset detector: src/com/mostc/pftt/model/core/PhptTestCase.java | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-68283@lists.php.net to get a copy of this message | ||
Commit: 116d7f9d257bec4fc0bb461eb22dfbb554780ce3
Author: Anatol Belski <ab@php.net> Sun, 30 Dec 2018 14:05:20 +0100
Parents: 426db571884c7b17b285a468f55d4f78e9bae1b9
Branches: revamp_3
Link: http://git.php.net/?p=pftt2.git;a=commitdiff;h=116d7f9d257bec4fc0bb461eb22dfbb554780ce3
Log:
Always use charset detector
This might be an overkill, but otherwise the most of multibyte tests
fail. Improvement is still needed, especially upgrade to newer ICU.
Changed paths:
M src/com/mostc/pftt/model/core/PhptTestCase.java
Diff:
diff --git a/src/com/mostc/pftt/model/core/PhptTestCase.java
b/src/com/mostc/pftt/model/core/PhptTestCase.java
index 83f6146..51d8758 100644
--- a/src/com/mostc/pftt/model/core/PhptTestCase.java
+++ b/src/com/mostc/pftt/model/core/PhptTestCase.java
@@ -173,8 +173,8 @@ public class PhptTestCase extends TestCase {
test_case.parent = parent;
DefaultCharsetDeciderDecoder cdd = newCharsetDeciderDecoder();
- ByLineReader reader = PhptTestCase.isNon8BitCharset(test_case.name) ?
host.mReadFileDetectCharset(file, cdd) : host.mReadFile(file);
-
+ //ByLineReader reader = PhptTestCase.isNon8BitCharset(test_case.name) ?
host.mReadFileDetectCharset(file, cdd) : host.mReadFile(file);
+ ByLineReader reader = host.mReadFileDetectCharset(file, cdd);
String line = reader.readLine();
if (!line.startsWith("--TEST--")) {