com pftt2: fix configuration bug for mbstring PHPT tests: src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
| From: | Anatol Belski | Date: | Fri, 12 Jul 2013 20:50:59 +0000 |
| Subject: | com pftt2: fix configuration bug for mbstring PHPT tests: src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java |
||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-68363@lists.php.net to get a copy of this message | ||
Commit: ae78cde1c7cc4b51728852ceb67aa9d42a55a0b0
Author: Matt Ficken <v-mafick@microsoft.com> Fri, 12 Jul 2013 13:50:59 -0700
Parents: d8f6dbab1a5fa3b1e4c5958c8960989d0a928dec
Branches: master
Link: http://git.php.net/?p=pftt2.git;a=commitdiff;h=ae78cde1c7cc4b51728852ceb67aa9d42a55a0b0
Log:
fix configuration bug for mbstring PHPT tests
Former-commit-id: a839e18932f354c1e8766c88d039b6ae8f45007b
Changed paths:
M src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
M src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
Diff:
diff --git a/src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
b/src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
index f0dce90..6677bc8 100644
--- a/src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
+++ b/src/com/mostc/pftt/runner/AbstractLocalTestPackRunner.java
@@ -811,6 +811,7 @@ public abstract class AbstractLocalTestPackRunner<A extends ActiveTestPack, S
ex
|| name.equals("ext/mbstring/tests/mb_ereg_replace_variation1.phpt")
|| name.equals("ext/phar/tests/phar_dotted_path.phpt")
|| name.equals("ext/session/tests/027.phpt")
+ || name.startsWith("ext/mbstring/tests/mb_output")
|| name.equals("ext/mbstring/tests/mb_ereg_replace_variation1.phpt")
|| name.equals("ext/phar/tests/cache_list/frontcontroller13.phpt")
|| name.equals("ext/phar/tests/frontcontroller29.phpt")
diff --git a/src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
b/src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
index d96794e..8d10fdc 100644
--- a/src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
+++ b/src/com/mostc/pftt/runner/LocalPhptTestPackRunner.java
@@ -229,6 +229,19 @@ public class LocalPhptTestPackRunner extends
AbstractLocalTestPackRunner<PhptAct
for ( EPhptTestStatus status : EPhptTestStatus.values() ) {
cm.println(EPrintType.CLUE, getClass(), status+" "+phpt.count(status)+"
tests");
}
+ // show (some) of the failing tests (for convenience)
+ int fail_count = phpt.count(EPhptTestStatus.FAIL);
+ if (fail_count > 0) {
+ int show_count = 0;
+ for ( String test_name : phpt.getTestNames(EPhptTestStatus.FAIL)) {
+ cm.println(EPrintType.CLUE, getClass(), "Failing test: "+test_name);
+ show_count++;
+ if (show_count >= 20) {
+ cm.println(EPrintType.CLUE, getClass(), "And "+(fail_count-show_count)+" more
failing test(s)");
+ break;
+ }
+ }
+ }
cm.println(EPrintType.CLUE, getClass(), "Pass Rate(%): "+phpt.passRate());
}