Re: [SMARTY-DEV] Errors in CVS

Hi! >> Warning: Uninitialized string offset: -1 in >> .../lib/Smarty/Smarty_Compiler.class.php on line 332 >> >> It is raised only when compiling an empty template with only one line with >> comment (newline after it exists) >> >> {* empty Smarty template *} mm> hmm, i'm sure this was fixed some time ago, maybe in my mm> dreams. anyway, it should be silent now, please test. It could be the result of other changes, since comments now eat the newline, if I remember right. >> Warning: Undefined offset: 4 in .../lib/Smarty/Smarty_Compiler.class.php on >> line 2001 >> >> Warning: Undefined offset: 4 in .../lib/Smarty/Smarty_Compiler.class.php on >> line 2019 mm> did you flush your templates_c after "cvs upd"? this may help already. Yes, of cause. Actually, these 3 warnings were raised at the same moment. I'll check tomorrow. >> Warning: Undefined property: params in >> .../lib/Smarty/core/core.write_compiled_include.php on line 33 >> >> It is triggered at >> {include file='admin/pager.html'} >> when that template should be compiled. >> I cannot say what is the matter: other template includes are compiled >> without warnings. mm> fixed, thanks. >> Please, remove '\r' at lines 30 and 38 in modifier.debug_print_var.php . >> They are not necessary for JavaScript debug output, but they make it bad >> looking in case of simple HTML debug output >> ( $smarty->assign('_smarty_debug_output','html'); ) mm> i don't know of any cross-browser implications or why a \r is emitted mm> there. let's wait if anyone on the list knows a reason for \r not mm> being \n and \r being there at all. Look at it, '\r', not "\r". It is passed into debug template as is and sent to browser as is, not as CR. If it is really needed, it may be better to use |escape:"javascript" in the debug template. WBR, Konstantin A. Pelepelin