Re: [SMARTY] Re: object calls fail after upgrade to 2.6.4

Unit test update and multiple param problem fixed and committed to CVS. unit_test passes inspection. Monte Hans_JXrgen_von_Lengerke wrote:

Hi Monte, Monte Ohrt wrote:

I committed CVS the ability to put objects in arbitrary parameter positions. See if that works, and thanks for testing.

This one works now

{$obj->meth("foo", $obj->val)}

but the 1.339 fix for Smarty_Compiler.class.php introduced another variant of the problem, that wasn't present before. {$obj->meth($foo, 2.5)} fails now. I saw the regex you're working on and it looks scary. Without trying to be patronizing, I really think that the unit test should be added to the test suite. Hans !DSPAM:4140be3081221301518572! ------------------------------------------------------------------------ hj@spirit:~/smarty_2_6_4/libs> cvs -q upd -r1.338 Smarty_Compiler.class.php P Smarty_Compiler.class.php hj@spirit:~/smarty_2_6_4/libs> cd - /home/entw/hj/smarty_2_6_4/unit_test hj@spirit:~/smarty_2_6_4/unit_test> phpcli ./smarty_unit_test.php Fatal error: Smarty error: [in assign_obj.tpl line 5]: syntax error: unrecognized tag: $obj->meth("foo", $obj->val) (Smarty_Compiler.class.php, line 411) in /home/entw/hj/smarty_2_6_4/libs/Smarty.class.php on line 1083 hj@spirit:~/smarty_2_6_4/unit_test> cd - /home/entw/hj/smarty_2_6_4/libs hj@spirit:~/smarty_2_6_4/libs> cvs -q upd -rHEAD Smarty_Compiler.class.php P Smarty_Compiler.class.php hj@spirit:~/smarty_2_6_4/libs> cd - /home/entw/hj/smarty_2_6_4/unit_test hj@spirit:~/smarty_2_6_4/unit_test> phpcli ./smarty_unit_test.php Fatal error: Smarty error: [in assign_obj.tpl line 1]: syntax error: unrecognized tag: $obj->meth($foo, 2.5) (Smarty_Compiler.class.php, line 413) in /home/entw/hj/smarty_2_6_4/libs/Smarty.class.php on line 1083 !DSPAM:4140be3081221301518572!