Re: [SMARTY-DEV] "url"-type in escape modifier

On Fri, Jan 28, 2005 at 10:04:46AM -0600, Monte Ohrt wrote: > Good catch. Actually this does not work on any browser. > > http://www.foo.com/foo%20.html <-- ok > http://www.foo.com/foo+bar.html <-- not > ok > > http://www.foo.com/foo.html?foo=bar+baz > http://www.foo.com/foo.html?foo=bar%20baz <-- equivalent > > > "+" will convert to a space in the QUERY_STRING, but not in the file path. > > I vote +1 to change it, or %201 as it may be. hehe, %2B1 that is, i think :) i've committed it. greetings messju > Monte > > messju mohr wrote: > > >Hello, > > > >I just noticed, that smarty's escape-modifier uses php's urlencode() > >when used like "{$var|escape:url}". > > > >I suggest changing this to rawurlencode(). > > > >The "+" sign for a space (when converted by urlencode()) seems to make > >problems in Firefox 1.0, for example. The RFC-1738-compliant "%20" > >(when converted by rawurlencode) doesn't seem to make any problems. > > > >Are there any objections against changing this? > > > >greetings > >messju > > > > > >