Re: [SMARTY-DEV] [patch] code cleanup
| From: | messju mohr | Date: | Tue, 29 May 2007 16:30:10 +0000 |
| Subject: | Re: [SMARTY-DEV] [patch] code cleanup | ||
| References: | 1 2 3 4 | Groups: | php.smarty.dev |
| Request: | Send a blank email to php-smarty-dev+get-3016@lists.php.net to get a copy of this message | ||
On Tue, May 29, 2007 at 06:19:15PM +0200, Giovanni Giacobbi wrote:
[...]
> > and I'm -1 on changing and/or touching {strip} in any way.
> >
>
> Why not? Should I read the code again or it is really pointless that "if" statement?
this was regarding your first mail:
> Smart_Compiler.class.php, _compile_tag():
> splitted "strip" and "/strip" handling, i'm not 100% about
> correctness of this change.
and not regarding any spaces around any if-keywords.
> Mine should be equivalent.
>
> Thanks, regards