unneeded statement?
| From: | Dennis Gearon | Date: | Thu, 20 Feb 2003 08:35:53 +0000 |
| Subject: | unneeded statement? | ||
| Groups: | php.smarty.dev | ||
| Request: | Send a blank email to php-smarty-dev+get-768@lists.php.net to get a copy of this message | ||
In function smarty._fetch_template_info()
In the second major 'if' block inside that function
In version 2.4.2 (maybe others)
line 1615 which reads
' $_return = false;'
this seems totally redundant. That block of code containing that variable '$_return'
cannot be reached unless '$_return' is *already* false, and there is nothing between the
if
statement testing for $_return== false (line 1610), which modifies $_return. So, $_return will
always be false at line 1615 and there is no need to set it false.
Also, wouldn't:
'FALSE'
'TRUE'
reveal that they're constants a little more clearly?