Re: [SMARTY] smarty updates: cache/compile stuff
| From: | Monte Ohrt | Date: | Fri, 14 Jun 2002 19:45:40 +0000 |
| Subject: | Re: [SMARTY] smarty updates: cache/compile stuff | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.smarty.general |
| Request: | Send a blank email to php-smarty-general+get-4869@lists.php.net to get a copy of this message | ||
As it stands, %2F is hardcoded regardless of OS. This may not be 100% proper, but it is definately faster than calling bin2hex for each file.
I think no matter what we use you may find conflicts. "_" or "__" or "___" will definately be a problem. That is why %2F at least you know it is a url encoded value, you know _which_ url encoded value and it cannot cause conflict.
Daniil Kaltchenko wrote:
Hi, Monte, I disagree, that compiled files nobody looks. They contain the information useful to debugging. For example date of compilation. Very much it would not be desirable to see in names "%2F". And unless will not be urlcodin to depend from OS? In windows and in unix DIR_SEP different - there will be a different code. And it is not so good. I like idea of usage "__" it is possible to use and "%". Others users are silent, as yet have not realized as the cache will look. To a good thing (like Smarty) everything should be beautiful, both appearance and an interior :-) (cache). Please, do not leave this subject! It-- Monte Ohrt <monte@ispi.net> Director of Technology, ispi Inc.would not be desirable to leave as is now with "%2F".Daniil Friday, June 14, 2002, 1:40:09 AM, you wrote: MO> I thought about that, and throught about using "_" too. But if you have MO> underscores in your path names it could look really confusing. I opted MO> for url escapement just to be consistant. Not real pretty, but no one MO> looks at these files anyways, right? ;-) MO> Daniil Kaltchenko wrote:Hi, Monte. I agree with you, that we don't need to use subdirectories. But "%2F" isn't artistic :) and yet isn't even convenient! Perhaps we can change directory separator to "_". Other symbols for urlcoding will occur much rarely, if actually will be used in filepaths. Daniil Wednesday, June 12, 2002, 10:33:22 PM, you wrote: MO> Smarty only needs directories built from cache_id and compile_id values. MO> All templates within a certain cache_id/compile_id get created as single MO> filenames. They don't really _need_ to be in subdirectories beyond that. MO> I suppose we could split up files based on the resource path so they MO> more closely represent the structure under template_dir, although that MO> adds to the complexity of the filepaths and will take extra cycles to MO> remove. MO> Matthias Pfafferodt wrote:Hi all, after the update to the newest cvs-version of smarty I get files like "dir%2Ffile.tpl.php" from my templates ("dir/file.tpl"). Why does smarty not create the directory? The config variable $use_sub_dir is set to true.