Re: [SMARTY] standart plugin(s) suggestion
| From: | Matthias Mohr | Date: | Thu, 20 Feb 2003 08:48:52 +0000 |
| Subject: | Re: [SMARTY] standart plugin(s) suggestion | ||
| References: | 1 2 3 4 5 6 | Groups: | php.smarty.general |
| Request: | Send a blank email to php-smarty-general+get-7978@lists.php.net to get a copy of this message | ||
Hallo André, ich schon wieder :-)
I currently looked at the changed version at the wiki.
Now it looks really good.
.
.
.
.
But (there's always a "but" - isn't it?)
.
.
.
I still have two small notes:
- as far as I know "ucfirst" does only work correctly, if the given string is all
lowercase.
So you have to do a "$type = ucfirst( strtolower($type) );"
- there are two typos in line 100:
if (empty($type) || $strlower($type) == "strict")
^
the "$" is wrong and the function's name is "strtolower"...
These are (hopefully) my last comments about your really good work :-)
with regards,
Matthias