RE: attribute namespace fix

> -----Original Message----- > From: George Schlossnagle [mailto:george@omniti.com] > Sent: Thursday, March 31, 2005 22:16 > To: Dmitry Stogov > Cc: George Schlossnagle; soap@lists.php.net > Subject: Re: attribute namespace fix > > > > On Mar 31, 2005, at 1:14 PM, Dmitry Stogov wrote: > > > Hi George, > > > > I think your patch isn't fully correct. > > It didn't look into attributeFormDefault of the <schema>. > > Are you ok with me modifying it to set attr->form in php_schema to > XSD_FORM_QUALIFIED or XSD_FORM_UNQUALIFIED based off the schema's > attributeFormDefault there? YES. This is right way. Also please look into elementFormDefault. For what reason is it? Thanks. Dmitry. > > Seems I didn't understand this during implementation. > > Or me when I pushed you to implement something the other day. :) > > > > > Thanks. Dmitry. > > > > > >> -----Original Message----- > >> From: George Schlossnagle [mailto:george@omniti.com] > >> Sent: Thursday, March 31, 2005 21:19 > >> To: Dmitry Stogov; soap@lists.php.net > >> Cc: George Schlossnagle > >> Subject: attribute namespace fix > >> > >> > >> Hi, > >> > >> The recent changes to the SOAP attribute namespacing aren't quite > >> correct. After a further reading of the namespacing scoping spec > >> (http://www.w3.org/TR/REC-xml-names/#scoping-defaulting) and > >> specifically schema spec > >> (http://www.w3.org/TR/xmlschema-0/#UnqualLocals) regarding > namespace > >> qualification, the logic should be: if an attribute is marked as > >> 'qualified' (i.e. attr-form == XSD_FORM_QUALIFIED) and if has a > >> namespace, then specify the namespace, otherwise don't.) > >> > >> I've prepared a patch and attached it. > >> > >> > >> > > > > > George Schlossnagle > > -- Prinicipal Consultant > -- OmniTI Computer Consulting > -- http://www.omniti.com > >