Re: [PHP4BETA] RFC: Request startup optimization

On Fri, 11 Feb 2000 thies@digicol.de wrote: > On Fri, Feb 11, 2000 at 07:59:50PM +0200, Zeev Suraski wrote: > > Generally I'm -1 for the change if there's no significant noticeable > > change. There's a considerable penalty for the shutdown process involved > > with this patch, and if the gain is unnoticeable, I don't see the point > > (that's what we arrived at in the PDM, as far as I recall). > > zeev, let's wait for some "real-life" benchmarks (if there is > such thing). in general i would say that anything that > improves performance (and this patch is designed to do so) is > a GoodThing(tm). It's a tradeoff patch, it's not a clear performance improver. For instance, if you happen to use functions that belong to these modules often, your performance will be degraded. Generally I agree. The patch I'd like to make the most is something that delays the startups the first PHP block is found, so that we save the request startup/shutdown completely for blank HTML pages with no HTML code. The patch that saves request startups was a nice idea, but I kinda laid off it even at the PDM. > again, i hope to do some more testing later. > > BTW: i don't know what part of the patch will cause the > "considerable penalty for the shutdown"? You have to restore the function entries to the stubs. Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/