Re: [PHP4BETA] cvs: /php4/ext/standard string.c

I was sitting with Stas when he found this problem. I'm actually not sure this is the right fix although it fixes his problem. php_tag_find() and php_strip_tags() right now still look as if they need some code review. Andi On Sun, 13 Feb 2000, Wico de Leeuw wrote: > Hiya > > Let's hope this will fix the bug... > compiling the cvs takes about an hour over here :) > > Greetz, > > Wico > > and keep up the good work > > At 15:36 13-2-2000 +0000, Zeev Suraski wrote: > >zeev Sun Feb 13 07:36:21 2000 EDT > > > > Modified files: > > /php4/ext/standard string.c > > Log: > > - Hopefully fix strip_tags bug > > @- Fix overrun in strip_tags (Stas, Zend library) > > > > > >Index: php4/ext/standard/string.c > >diff -u php4/ext/standard/string.c:1.97 php4/ext/standard/string.c:1.98 > >--- php4/ext/standard/string.c:1.97 Sun Feb 13 06:56:35 2000 > >+++ php4/ext/standard/string.c Sun Feb 13 07:35:51 2000 > >@@ -18,7 +18,7 @@ > > +----------------------------------------------------------------------+ > > */ > > > >-/* $Id: string.c,v 1.97 2000/02/13 14:56:35 thies Exp $ */ > >+/* $Id: string.c,v 1.98 2000/02/13 15:35:51 zeev Exp $ */ > > > > /* Synced with php 3.0 revision 1.193 1999-06-16 [ssb] */ > > > >@@ -2265,8 +2265,8 @@ > > if(allow) { > > *(tp++) = '>'; > > *tp='\0'; > >- if(php_tag_find(tbuf, > >tp-tbuf, allow)) { > >- > >memcpy(rp,tbuf,tp-tbuf); > >+ if(php_tag_find(tbuf, > >tp-tbuf+1, allow)) { > >+ > >memcpy(rp,tbuf,tp-tbuf+1); > > rp += tp-tbuf; > > } > > tp = tbuf; > > > > > > > >-- > >PHP 4.0 Beta Mailing List > ><http://www.php.net/version4/> > >To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net > >For additional commands, e-mail: php4beta-help@lists.php.net > >To contact the list administrators, e-mail: php4beta-admin@lists.php.net > > >