Re: [PHP4BETA] cvs: /php4 SAPI.c /php4/sapi/isapi php4isapi.c /php4/sapi/servlet servlet.c
| From: | thies at digicol dot de | Date: | Wed, 16 Feb 2000 13:55:00 +0000 |
| Subject: | Re: [PHP4BETA] cvs: /php4 SAPI.c /php4/sapi/isapi php4isapi.c /php4/sapi/servlet servlet.c | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-10340@lists.php.net to get a copy of this message | ||
On Tue, Feb 15, 2000 at 11:31:08PM -0000, Zeev Suraski wrote:
> zeev Tue Feb 15 15:31:08 2000 EDT
>
> Modified files:
> /php4 SAPI.c
> /php4/sapi/isapi php4isapi.c
> /php4/sapi/servlet servlet.c
> Log:
> @- Improved ISAPI module - it should no longer be necessary to set PHP as
> @ an ISAPI filter, only as an ISAPI extension, unless you wish to perform
> @ authentication using PHP. This didn't yet get enough testing, but it
> @ should work (Zeev)
> - Fixed auth_user/auth_password memory leak (I didn't have time to test it under
> Apache, feedback welcome!)
>
>
> Index: php4/SAPI.c
> diff -u php4/SAPI.c:1.52 php4/SAPI.c:1.53
> --- php4/SAPI.c:1.52 Fri Feb 11 07:59:26 2000
> +++ php4/SAPI.c Tue Feb 15 15:31:08 2000
> @@ -178,6 +178,7 @@
> SG(request_info).post_data = NULL;
> SG(request_info).current_user = NULL;
> SG(request_info).current_user_length = 0;
> + SG(request_info).auth_user = SG(request_info).auth_password = NULL;
^^^^^
this line breaks apache authorisation - PHP_AUTH_USER,
PHP_AUTH_PW are no longer set.
i'm not quite sure where we want this - zeev, could you
please have a look?