RE: [PHP4BETA] cvs: /php4/sapi/isapi php4isapi.c

That's really strange. I'm using IE5 and using a phpinfo() test script I can press reload a zillion times and it works. I even kept my finger on control-R in order to stress test it. Are you compiling in debug or release mode? Andi At 10:37 AM 2/17/00 +0100, Mikkel Staunsholm wrote:

Andi, Zeev, The patches you have comitted lately to php4isapi.c really have helped a lot, unfortunately not enough. Using a 'phpinfo()' test script, it still crashes the 3rd or 4th time I press reload (which I guess is the same as pressing stop). There is a difference though, cause the 1st time it crashes it returns: "Access violation" to the browser. Still trying to get that debug working... Mikkel. On Wednesday, February 16, 2000 2:35 PM, Andi Gutmans [SMTP:andi@php.net] wrote:

andi          Wed Feb 16 05:34:37 2000 EDT

Modified files:

    /php4/sapi/isapi  php4isapi.c

Log: - In IIS ISAPI when the user presses the STOP button while the script is

    running make sure it stops gracefully. Before it stuck the server.

Index: php4/sapi/isapi/php4isapi.c diff -u php4/sapi/isapi/php4isapi.c:1.25 php4/sapi/isapi/php4isapi.c:1.26 --- php4/sapi/isapi/php4isapi.c:1.25 Tue Feb 15 15:31:08 2000

+++ php4/sapi/isapi/php4isapi.c       Wed Feb 16 05:34:07 2000

@@ -136,9 +136,12 @@

      DWORD num_bytes = str_length;
      LPEXTENSION_CONTROL_BLOCK ecb;
      SLS_FETCH();
+     ELS_FETCH();

      ecb = (LPEXTENSION_CONTROL_BLOCK) SG(server_context);
-     ecb->WriteClient(ecb->ConnID, (char *) str, &num_bytes, HSE_IO_SYNC );
+     if (ecb->WriteClient(ecb->ConnID, (char *) str, &num_bytes, HSE_IO_SYNC

) == FALSE) {

+             longjmp(EG(bailout), 1);
+     }
      return num_bytes;

} -- PHP 4.0 Beta Mailing List <http://www.php.net/version4/> To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net For additional commands, e-mail: php4beta-help@lists.php.net To contact the list administrators, e-mail: php4beta-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/